[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Improve startup time of csi by avoiding so
|
From: |
felix . winkelmann |
|
Subject: |
Re: [Chicken-hackers] [PATCH] Improve startup time of csi by avoiding some merge-se calls |
|
Date: |
Sat, 28 Apr 2018 23:39:06 +0200 |
> On Fri, Apr 27, 2018 at 01:20:36PM +0200, Peter Bex wrote:
> > Hi all,
> >
> > The first patch is just a similar change to 097053f, which was
> > incomplete: iexprs never contains any syntax, so we don't need to
> > patch up any syntax environments in it.
> >
> > The second patch will speed up the startup time of csi a little
> > by avoiding unneccessary work in register-compiled-module: when a module
> > does not export any macros, we do not need to create a fresh syntax
> > environment because there is nothing to patch up.
>
> This patch contains a bug; we should use OR instead of AND, because
> if either sexps or nexps are available, we need to calculate the new
> senv.
>
> Attached is a new version (and for completeness, I've attached the
> first patch again, too).
Pushed.
felix