[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] chicken.h: identify arm64 architectures

From: Mario Domenech Goulart
Subject: Re: [Chicken-hackers] [PATCH] chicken.h: identify arm64 architectures
Date: Sun, 08 Jul 2018 11:10:49 +0200

Hi Evan,

On Thu, 5 Jul 2018 21:03:02 +1200 Evan Hanson <address@hidden> wrote:

> Hey Mario,
> This seems fine to me in concept.
>> -#elif defined(__arm__)
>> +#elif defined(__arm__) && !defined(__arm64__) && !defined(__aarch64__)
>>  # define C_MACHINE_TYPE "arm"
>> +#elif defined(__arm64__) || defined(__aarch64__)
>> +# define C_MACHINE_TYPE "arm64"
> Can we check for just defined(__arm64__) && defined(__aarch64__) first
> and defined(__arm__) second?
> If so that would be simpler to read, no need for the !defined(...) bits.

Good point.  Thanks for pointing that out.  Attached is a cleaned up

All the best.

Attachment: 0001-chicken.h-identify-arm64-architectures.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]