Re: [Chicken-hackers] [PATCH] Make (repository-path) return a list

[felix . winkelmann]

> As discussed on IRC, it doesn’t make much sense to have
> (repository-path) return a string now that it’s a search path and thus
> is not guaranteed to be a valid directory name any longer.
>
> I tried to keep the scope of this patch as minimal as possible, it’s not
> very clean but it seems to be working. I added a few tests to ensure that.
>

Looks good! Pushed.

(Note: when pushing I got this:

remote:
remote: Error: (tcp-connect) cannot create socket - Connection refused
remote:
remote:         Call history:
remote:
remote:         <eval>    [process*] (file-close in-in)
remote:         <eval>    [process*] (file-close out-out)
remote:         <eval>    [process*] (file-close err-out)
remote:         <eval>    [process*] (values (open-input-file* out-in) 
(open-output-file* in-out) pid (open-input-file* err-in))
remote:         <eval>    [process*] (open-input-file* out-in)
remote:         <eval>    [process*] (open-output-file* in-out)
remote:         <eval>    [process*] (open-input-file* err-in)
remote:         <eval>    [git] (proc in)
remote:         <eval>    [git] (##sys#call-with-values (##core#lambda () 
(process-wait pid)) (##core#lambda (_ ok? status/signal) (...
remote:         <eval>    [git] (process-wait pid)
remote:         <eval>    [git] (zero? status/signal)
remote:         <eval>    [git] (close-input-port err)
remote:         <eval>    [git] (close-input-port in)
remote:         <eval>    [git] (close-output-port out)
remote:         <eval>    [process-ref-change] (##sys#call-with-values 
(##core#lambda () (tcp-connect "localhost" 22722)) (##core#lambda (vin121 vo...
remote:         <eval>    [process-ref-change] (tcp-connect "localhost" 22722)  
<--

Probably some broken git hook?)


felix