[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH] Drop module namespace from struct type in `##sys#make-structure' specialisation |
Date: |
Fri, 24 Aug 2018 09:43:31 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Fri, Aug 24, 2018 at 07:32:52PM +1200, Evan Hanson wrote:
> On 2018-08-24 9:27, Peter Bex wrote:
> > I'd prefer to add the current module to struct type declarations, instead.
> > This should be equally simple; I think we can add this to validate-type's
> > handling of struct: if the struct is not qualified, add the current
> > module (if any).
>
> That approach has the problem megane described on the ticket. When it's
> used, we don't have enough info to disambiguate one struct type from
> another, unless you expect users to include a module prefix manually in
> all cases. I think that's too big a change for 5.0.
OK, I see what you're saying. I think you're right; this is the correct
approach in the meantime and should be (mostly) backwards-compatible once
we figure out a good way to import and rename/prefix types from modules.
Cheers,
Peter
signature.asc
Description: PGP signature