[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Chicken-hackers] [PATCH 2/2] * scrutinizer.scm (refine-types): Add
From: |
Peter Bex |
Subject: |
Re: [Chicken-hackers] [PATCH 2/2] * scrutinizer.scm (refine-types): Add special case for (or pair null) and list-of |
Date: |
Sun, 23 Sep 2018 12:01:06 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Sep 18, 2018 at 01:01:55PM +0300, megane wrote:
> Hi,
>
> Here's a patch for #1533. The fix itself is pretty simple.
>
> The first patch makes scrutinizer tests give more info when a test
> fails, which makes it faster to figure out these refinement issues.
Looks good to me, thanks! Here's a signed-off copy.
One minor nitpick: I see you've introduced the [] style of brackets.
We've deprecated those for core, instead of adding new ones we prefer
to remove the ones that are still in there (but only if there's a
patch that affects a region where there are []). Could you please take
this into consideration next time?
Cheers,
Peter
0001-tests-scrutinizer-tests.scm-test-Add-more-informatio.patch
Description: Text Data
0002-scrutinizer.scm-refine-types-Add-special-case-for-or.patch
Description: Text Data
signature.asc
Description: PGP signature