chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Avoid dropping -emit-types-file and -emit-


From: Peter Bex
Subject: Re: [Chicken-hackers] [PATCH] Avoid dropping -emit-types-file and -emit-inline-file when compiling statically
Date: Sat, 13 Oct 2018 12:31:48 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Sat, Oct 13, 2018 at 11:44:27AM +0200, address@hidden wrote:
> > The patch is very straightforward: it simply removes the offending
> > code that drops these options.
> 
> I'm not sure this is right. You simply disable this without really
> addressing the problem. The types-file should remain, removing
> it externally (by "hg clean" or whatever) breaks the dependency
> chain. I don't yet know what the proper solution is, but simply dropping
> it doesn't look right to me (this piece of code was not done for
> performance reasons, btw, but to avoid changing timestamps).

Ah, I see.  Perhaps a better solution is to add the types file as
a dependency of anything that depends on a component that emits a
types file?  This would also require teaching chicken-do that the
types file is a generated file of the component.

Cheers,
Peter

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]