[Chicken-hackers] [PATCH] Fix segfault in get-environment-variable and three C compiler warnings

[Peter Bex]

Hi all,

Moritz was compiling CHICKEN with gcc 7 (or perhaps a newer libc?) that
gave warnings like "null argument where it was not expected".  The
attached patch fixes those warnings, and I also noticed that if you
call get-environment-variable with #f as an argument, you would get a
segmentation fault.

I noticed that the other two places; file-link and set-root-directory!
already explicitly check the argument(s) for being strings.  The patch
is the smallest possible change to get rid of the compiler warnings and
also fix the segfault, but perhaps we want to remove those checks from
posixunix.scm, given that they're strictly redundant.  Or, we might
add such a check to library.scm because the error message is a bit
better when it includes the procedure name, and none of these procedures
should be very performance-sensitive anyway.

Cheers,
Peter

0001-Change-definition-of-link-chroot-and-C_getenv-from-c.patch
Description: Text Data

signature.asc
Description: PGP signature