Re: [Chicken-hackers] ⍄PATCH⍃ Unboxing optimization for flonums

[Mario Domenech Goulart]

Hi,

On Mon, 26 Nov 2018 12:32:19 +0100 address@hidden wrote:

> Thanks, your suggestions seem to be correct, I applied the patch and removed
> the last call to sub-boxed!. I also added a (very simple) test.
>
>> - Finally: there are still quite some remnants of the old boxing/unboxing
>>    code around to mark variables as 'boxed, and there's still ##core#box
>>    and ##core#unbox in the intermediate language.
>> 
>>    Is that still relevant, or can we delete that too?  As far as I can
>>    tell, that code is still active and used; could you tell me more about
>>    how it works and how it relates (or not) to the lfa2 boxing and
>>    unboxing step, especially why the patch introduces a new box_float
>>    operation rather than re-using the old intermediate language box/unbox
>>    operations?
>
> ##core#box/##core#unbox are unrelated, they access boxed variables
> in closures (1-element vectors).

It looks like this patch (79cf7427, master) has broken "make
bootstrap".  Log attached (using CHICKEN 5.0.0 as CHICKEN).

All the best.
Mario
-- 
http://parenteses.org/mario

make-bootstrap.txt
Description: Text document