Re: [Chicken-hackers] [PATCH] Improve hygiene of FFI macros

[Peter Bex]

On Tue, Apr 09, 2019 at 12:48:16PM +0200, Peter Bex wrote:
> The patch is somewhat large but straightforward.  It replaces all uses of
> just "quote" (via the single quote character) to "##core#quote"

Hi all,

This patch contains one bug; in canonicalize-expression, I replaced a
quote by ##core#quote which wasn't walked, which means it would end up
in the canonicalized language as understood by perform-cps-conversion,
which only has plain unqualified "quote" (but that's *after*
macro-expansion, so it is unrelated to "quote" from the "scheme"
module).

This is only triggered in unsafe code, so when recompiling CHICKEN with
itself it would fail on scheduler.scm.

Attached is an updated version of my initial patch but without that one
patch hunk that broke canonicalize-expression.

Cheers,
Peter

0001-Improve-hygiene-of-FFI-macros.patch
Description: Text Data

signature.asc
Description: PGP signature