chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Always quote symbols starting or ending with a


From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Always quote symbols starting or ending with a colon to ensure readability
Date: Sun, 26 May 2019 13:52:42 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Hi all,

We've seen quite a bit of breakage with the CR patch.  Most of it has
been fixed by aeec82d, but it also uncovered another bug that has been
there since the beginning.  Eggs using srfi-128 fail, see for example:
https://salmonella-freebsd-x86-64.call-cc.org/master/clang/freebsd/x86-64/2019/05/26/salmonella-report/install/srfi-113.html

This is because srfi-128 contains identifiers like :type-test:.  Now
that keywords can no longer be assigned to, I had to submit a pull
request to this egg to add "-keyword-style none" to the compilation
options, but apparently that causes the types file to be emitted without
pipe quotes around :type-tests: and other identifiers, so they will be
read as keywords unless the other egg also happens to use
"-keyword-style none".

The attached patch ensures we write such identifiers as |:type-tests:|
regardless of keyword style.  This way, it can also be read by any
program, even if it uses a different keyword style than the writer.

Cheers,
Peter

Attachment: 0001-Always-pipe-quote-symbols-starting-or-ending-with-a-.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]