Re: [Chicken-hackers] [PATCH] Fix #1620 by ignoring captured state of replaced variables

[megane]

Peter Bex <address@hidden> writes:

> On Wed, Jul 03, 2019 at 02:05:21PM +0200, Peter Bex wrote:
>> You're right, good catch!  That was an oversight on my part, I only
>> removed the captured check of the other variable.  I hope this makes
>> things faster in more cases.  I can make and test a new patch, but don't
>> know when I'll get around to it.  Possibly in the weekend.
>
> I tried this, but I got a crash when compiling CHICKEN with itself after
> having built it with this patch.
>
> I'm not even sure why it's doing this.  The offending procedure was
> append-map from mini-srfi-1, it's calling proc with the wrong number
> of arguments.
>

I reduced this case to this:

  (define (foo bindings)
    (define (append-map proc lst1)
      (if lst1
          (proc 1)
          (proc 1 2)))
    (append-map (lambda (b a) (begin)) bindings))

Error: ../fail.scm:5: proc: procedure `proc' called with wrong number of
arguments

This seems to be a separate optimizer issue as it triggers with 5.1.0rc1
and 4.13.0 too.