chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Chicken-hackers] [PATCH] Fix #1625 and add srfi-88 module plus feat


From: Evan Hanson
Subject: Re: [Chicken-hackers] [PATCH] Fix #1625 and add srfi-88 module plus feature identifier
Date: Fri, 12 Jul 2019 21:02:47 +1200

Hi Peter,

Very nice work, I've pushed these. Thanks for the detailed explanation.

On 2019-06-29 17:10, Peter Bex wrote:
> The second patch completes SRFI-88 support by registering a module
> for it and adding the feature identifier (which I think was just an
> oversight).  Strictly speaking, we might not define the identifier
> when keyword mode is prefix or none, but then we still do have the
> srfi-88 procedures, so I'm not 100% sure.
> 
> We could let the features procedure check the keyword style and add
> srfi-88 dynamically if it's #:suffix only...

Yeah, I'm not sure. I can see it both ways. Oh well, that can follow if
we decide it's best, but I didn't want to hold these patches up for now.

Cheers,

Evan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]