Re: [Chicken-hackers] [PATCH] Detect self-reference in "letrec"

[Peter Bex]

On Wed, Aug 28, 2019 at 01:41:22PM +0200, address@hidden wrote:
> An attempt to fix #1645. See commit message for more details.

Hi Felix,

I've taken a look at it and the logic itself looks good, but I find the
usage of fluid-let on a global variable unsettling.  Why not pass the
list in "walk" to itself and to "resolve-variable"?

If that's too unwieldy, I would at least put the variable inside
"canonicalize-expression" to clarify that it's only used there.

Cheers,
Peter

signature.asc
Description: PGP signature