chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Chicken-hackers] [PATCH] Fix how chicken-install handles server errors


From: Peter Bex
Subject: [Chicken-hackers] [PATCH] Fix how chicken-install handles server errors and add redirect support
Date: Sun, 15 Sep 2019 16:25:08 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

Hi all,

We noticed in yesterday's Salmonella run that chicken-install isn't
handling HTTP error codes correctly:

https://salmonella-freebsd-x86-64.call-cc.org/master/clang/freebsd/x86-64/2019/09/15/yesterday-diff/log2/install/zmq.html

As you can see, we get a compiler error on an HTML document which is
being processed as Scheme code.

After a quick look at egg-download.scm, it become clear that the handling
for error codes was wrapped only inside the code that handled 407 codes.
That code itself did not look correct either, because it would not read
the response line or headers after sending the new request through the
proxy.  The first patch fixes these issues.

While in there, I decided that adding support for redirects shouldn't
be too hard, so that's what the second patch does.

Cheers,
Peter

Attachment: 0001-Fix-egg-download-response-handling.patch
Description: Text Data

Attachment: 0002-Handle-301-302-redirects-in-chicken-install.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]