Re: [PATCH] Pick rest argument values directly from the argvector without consing

[felix . winkelmann]

Hi!


Very nice, works well and makes sense. Here a few suggestions:

- For new optimizations, I'd add 'x to the debugging flags given
   to "debugging", that way one can easily see new or experimental
   compiler features at work an whether they cause trouble.

- The implementation of C_get_rest_arg is confusing, you should throw
   a proper error there, this can be done with a small runtime function or
   macro.

- The detection of (##core#cond (null? r) ...) might be easier to read
   using the "match-node" helper procedure in support.scm.

- Internal errors should use "bomb", not "quite-compiling" (for consistency's
   sake).

- support.scm:/replace-rest-ops-in-known-call!/: here I would also try to use
  an explicit error instead of depending on car/cdr of ()


cheers,
felix