[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amoun
Re: [PATCH 0/1] Prevent excessive major gcs by preserving a decent amount of unused heap
Sun, 29 Mar 2020 10:15:09 +1300
Uh, sorry, this is in reference to megane's email from January 8. Forgot
to fill in the "In-Reply-To"!
On 2020-03-29 10:10, Evan Hanson wrote:
> Hi there,
> I've played around with this first patch a bit, and I think I've found a
> way to apply the same technique without complicating the logic in
> C_reclaim(). Attached is a sign-off of megane's patch that introduces
> the same min-free requirement, but only at the point where reallocations
> are triggered. This actually gives a minor performance improvement over
> the initial version (which itself is a significant improvement over
> master), and it's a less invasive change because it leaves the heap
> resizing logic unchanged.
> Here are the benchmarks -- review-0001 (in the middle) is the original
> patch, and review-1001 (on the right) is this version:
> (I also played around with the initial and min-free heap values but
> couldn't find any improvements that way.)
> megane, could you please have a look at this version and confirm the
> results? I'm keen to get this reduction in major GCs, so I'm hoping a
> simpler version of the patch is OK.