Re: [Chicken-hackers] [PATCH] Rework library loading to support conditional unit entry

[Evan Hanson]

Hi there,

On 2018-11-12  9:08, Evan Hanson wrote:
> On 2018-11-11 21:03, Peter Bex wrote:
> > I think now's a good time to revisit this patch.  Of course it no longer
> > applies.  Would you care to rebase it?
> 
> Yeah, I will do so, thanks. You can just ignore it until I can prepare a
> new version.

I've finally gone back and revived this patch, rebased it and made a few
improvements. Everything I said in the earlier email is still true, but
this version is actually smaller since I was able to simplify a few
things and rip out some unnecessary changes. It still looks pretty big,
but a lot of the changes are just shuffling forms around so using git
with --color-words should help, especially in core.scm and eval.scm.

The one change to the tests is there because, with this patch,
test-static-eval-compiled.scm will only enter the lolevel unit at line 8
where the chicken.memory.representation module is imported. So, that
unit needs to be loaded at the start of the program, before the eval'd
imports. Those first two lines are only working by accident, currently,
and they will cause an error if the import on line 8 is removed, for
example.

One thing I also should have pointed out is that this patch removes the
"-debug M" flag from csc. I think it isn't especially useful in its
current form, and I'm working on a more detailed way of generating
dependency information in an egg, but we can put it back if anyone feels
strongly.

Thanks, please let me know if I can help explain anything.

Evan

0001-Rework-library-loading-to-support-conditional-unit-e.patch
Description: Text document