chicken-hackers
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] Fix r7rs egg dependency list


From: Peter Bex
Subject: [PATCH] Fix r7rs egg dependency list
Date: Mon, 12 Apr 2021 10:47:27 +0200
User-agent: Mutt/1.10.1 (2018-07-13)

Hi all,

The fix for #1185 (topological-sort) seems to have caused quite a
regression on Salmonella.  See [1]; there are 22 eggs broken.  Most
of those seem to have a dependency on r7rs, which is broken.

It looks like the fix for topological-sort simply exposed bugs in
existing eggs because components were missing dependency specifications
on other components.  In the "bitstring" case that's pretty clear;
there's simply a missing dependency of "bitstring" on "bitstring-lowlevel".
This used to work because components would be built in the same order
they were specified (if nothing else caused a rearrangement).

If we look at the r7rs egg, it fails to build the "r7rs" module because
it doesn't know about the (scheme base) module.  This is because it
hasn't been built yet.  The attached patch seems to fix the situation by
declaring a dependency of r7rs on the various modules under the
"scheme" namespace.  I don't know if this is 100% correct (there
may be other modules depending on other modules), so please review
carefully.

I think fixing this egg will probably restore most of the breakage.

[1] 
https://salmonella-linux-x86-64.call-cc.org/master/gcc/linux/x86-64/2021/04/12/yesterday-diff/

Cheers,
Peter

Attachment: r7rs-dependencies.patch
Description: Text Data

Attachment: signature.asc
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]