[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add runtime option to fix randomization seed on startup
From: |
Mario Domenech Goulart |
Subject: |
Re: [PATCH] Add runtime option to fix randomization seed on startup |
Date: |
Wed, 23 Jun 2021 22:04:02 +0200 |
On Thu, 17 Jun 2021 16:27:21 +0200 Peter Bex <peter@more-magic.net> wrote:
> Megane looked into #1650 and found out that the srand(time(NULL)) call
> is the culprit; due to the hash table randomization the number of GCs
> can differ on every run.
>
> This led me to think that this could be one reason our benchmarks are so
> noisy, so I added a runtime option to fix the randomization factor on
> startup. This does indeed completely remove all deviation on the
> "number of major GCs" metric in the CHICKEN benchmarks, but unfortunately
> doesn't seem to do all that much for the cpu-time or GC time metrics.
>
> Oh well, I think it could be useful enough anyway, and perhaps a good
> first stab at reducing the noisiness of our benchmarks.
>
> The patch should speak for itself.
Thanks megane and Peter. I've pushed the patch.
All the best.
Mario
--
http://parenteses.org/mario