[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] component dependencies in eggs should be reflected in build
From: |
Mario Domenech Goulart |
Subject: |
Re: [PATCH] component dependencies in eggs should be reflected in build rules |
Date: |
Wed, 15 Feb 2023 19:23:02 +0100 |
Hi,
On Fri, 23 Dec 2022 08:22:01 +0100 felix.winkelmann@bevuta.com wrote:
> Originally reported by Mario, recently also noticed on #chicken.
> See commit message, fixes #1684.
Sorry about the long time to get back to you on this one. Somehow I
missed this thread.
I've tested your patch with the example in
http://paste.call-cc.org/raw?id=32c24ffb30a9bdffd4cc8b745da5f4e47d62e116&annotation=0
and could verify that it fixes the issue. Now foo.build.sh is produced
with:
'$PREFIX/bin/chicken-do' '$TMP/foo-egg/foo-exec' : 'foo-exec.scm' \
'$TMP/foo-egg/foo.egg' '$TMP/foo-egg/foo-lib.so' : '$PREFIX/bin/csc' \
'-setup-mode' '-host' '-I' '$TMP/foo-egg' '-C' '-I$TMP/foo-egg' '-O2' \
'-d1' 'foo-exec.scm' '-o' '$TMP/foo-egg/foo-exec'
(I've formatted the line for the sake of legibility.)
Now the library is added as a dependency of the executable.
I've pushed the patch. I took the liberty of cleaning up some
whitespaces and updating NEWS.
Thanks for the fix!
All the best.
Mario
--
http://parenteses.org/mario
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH] component dependencies in eggs should be reflected in build rules,
Mario Domenech Goulart <=