Re: [PATCH] bootstrap.sh: Use ftp instead of wget on OpenBSD

[Mario Domenech Goulart]

On Tue, 31 Dec 2024 20:35:28 +0000 Pietro Cerutti <gahr@gahr.ch> wrote:

> On Dec 20 2024, 09:41 +0000, felix.winkelmann@bevuta.com wrote:
>>> On Fri, Dec 20, 2024 at 08:56:23AM +0100, Mario Domenech Goulart wrote:
>>> > On Fri, 20 Dec 2024 08:12:44 +0100 Peter Bex <peter@more-magic.net> wrote:
>>> > > Maybe it's fine as it is?  I've never heard any complaints about it.
>>> > > What prompted you to come up with this patch in the first place?
>>> >
>>> > I was bootstrapping C6 on an OpenBSD box (without wget) for a salmonella
>>> > machine, and since I saw that there's a special case for FreeBSD I
>>> > thought it would be ok to have OpenBSD handled as well.
>>>
>>> OK, how about the attached patch then?
>>>
>>
>>Thanks, pushed.
>
> Can you please:
>
> diff --git a/scripts/bootstrap.sh b/scripts/bootstrap.sh
> index 93376cc4..60485e74 100755
> --- a/scripts/bootstrap.sh
> +++ b/scripts/bootstrap.sh
> @@ -14,7 +14,7 @@ case "$(uname)" in
>       *BSD)
>          # Counter-intuitively, the ftp(1) program on many
>          # BSDs supports both HTTP(S) and FTP
> -        getcmd=ftp;;
> +        getcmd=ftp
>           mkcmd=gmake;;
>   esac
>
>
> Thanks!

Thanks, Pietro, and sorry about that.

I pushed your fix (properly credited) directly, without a second review,
under the assumption that it is a trivial fix.  And also the fact that
bootstrap.sh was broken without it.

All the best.
Mario
-- 
http://parenteses.org/mario