Re: Patch 184 (FileURLConnection formatting changes)

[Brian Jones]

Nic Ferrier <address@hidden> writes:

> > >I'd very much like to submit the patch to Classpath but I don't want 
> > >to do that until the FileURLConnection patch has been approved. 

The formatting changes do not require approval, they seem benign.

> > I'm not sure that its a good idea to add extra methods to things like  
> > the URL protocol drivers, even though in this case it is in the gnu  
> > namespace. 
> 
> Ok. I asked here first and the only person to respond was Aaron and
> he responded positively.
> 
> I'll submit the patch and you guys can turn it down if you want.

All I see is the formatting patch which I'll commit soon enough.  

Although there is nothing wrong with adding methods to
gnu/java/net/protocol/file/FileURLConnection.java; it could create
problems for users expecting support for the continued usability of
methods unrelated to the public API we're attempting to be compatible
with.  Maybe if you could explain why you need those methods in
gnu/java/net/.../FileURLConnection and what they are it will make more
sense to me.  It seems like you should be trying to use the public API
provided rather than distort some particular backend of our
implementation.

Brian
-- 
Brian Jones <address@hidden>