Re: OSX port of classpath

[Tom Tromey]

>>>>> "Chris" == Chris Hoffmann <address@hidden> writes:

Chris> Any chance these can be folded into classpath 0.07?

Probably.

Chris> +++ classpath/native/fdlibm/ieeefp.h     Fri Oct  3 11:17:44 2003

This part looks fine to me.  It might be better to put this check in
with the other OS checks when __PPC__ is defined, though (that's what
we did in libgcj :-).

Could you do this and write a ChangeLog entry?  I'll check this bit
in.

Chris> +  INIT_FIELD ("in", ((long long)0));
Chris> +  INIT_FIELD ("out", ((long long)1));
Chris> +  INIT_FIELD ("err", ((long long)2));

Why did you need this?

Chris> +#ifndef O_SYNC
Chris> +#undef TARGET_NATIVE_FILE_FILEFLAG_SYNC
Chris> +#define TARGET_NATIVE_FILE_FILEFLAG_SYNC O_FSYNC
Chris> +#endif

This looks like something that should go in one of the target headers.

Chris> +#ifdef __MACH__
Chris> +typedef int    socklen_t;       
Chris> +#endif

Likewise.


BTW, I saw this in FileDescriptor.c:

#ifdef O_BINARY
  flags |= TARGET_NATIVE_FILE_FILEFLAG_BINARY;
#endif

That looks weird to me.  It would be cleaner to just always include
this, and let targets define it to 0.

Also, the target headers I looked at don't conform to the GNU coding
standard.

Tom