Re: [Classpathx-crypto] DOS characters in shell scripts.

[Raif S. Naffah]

hello Olivier and Nic,

thanks Nic for your encouragement and support.  my comments are in-lined 
below.


Olivier LF wrote:
> Raif,
>
> I have checkout the latest and noticed that all shell scripts and
> Makefiles have the DOS end-of-line character sequence (with the extra
> ^M).

yes you're right; i just checked them with (gVIM + Cream) --which i 
should have done instead of using that "intelligent" expensive IDE (you 
know what i'm talking about!).

i'll try to remember doing that every time i touch these files.


> As a result, all the gcj tool chain was broken on Unix!

sorry about that.


> I have fixed all the files under crypto/gcj and also changed few
> exe permissions for the shell scripts.
> For some of the files I had to remove them from CVS altogether and re-import.
> It should be working again now.

thanks.


> Next time you checkout, I recommend to remove the gcj directory...

noted.


> It is VERY important that all shell scripts and Makefiles use the Unix
> ending otherwise they won't work under Unix platforms (only Cygwin
> quietly filters the extra ^M)..
>
> In fact, it would propably be better if ALL the source code had the Unix
> ending, as the Primary target of the gnu project is GNU / Unix systems
> rather than Windows platforms.

if you check the java sources, you'll notive that this is the case.  i 
think the tool i use wants to be too smart when it comes to (what i 
considers) plain text files.

> Olivier
>
> PS: I'll start working on the JUnit test harness for GCJ soonish.

good to hear.


cheers;
rsn