Re: classpath/native/jni/java-io java_io_File.c

[Mark Wielaard]

Hi,

On Tue, 2003-08-19 at 10:59, Torsten Rupp wrote:
> Log message:
>       Fixed return value of 0 in Java_java_io_File_lastModifiedInternal()
> 

A better ChangeLog entry would have been:

        2003-08-19  Torsten Rupp  <address@hidden>
        
        * native/jni/java-io/java_io_File.c
        (Java_java_io_File_lastModifiedInternal):
        Change return value from 0 to
        TARGET_NATIVE_MATH_INT_INT64_CONST_0

On Tue, 2003-08-19 at 11:07, Torsten Rupp wrote:
> Modified files:
>       native/target/generic: target_generic_network.h 
> 
> Log message:
>       Fixed TARGET_NATIVE_NETWORK_GET_HOSTNAME() macro

Same comment as above (the ChangeLog entry should mention what was
changed, not just say 'fixed'). This patch also (re)moves a block:

-#ifdef __cplusplus
-extern "C" {
-#endif

This should also normally be mentioned in the ChangeLog entry.

On Tue, 2003-08-19 at 11:03, Torsten Rupp wrote:
> Modified files:
>       native/jni/java-nio: java_nio_FileChannelImpl.c 
> 
> Log message:
>       Fixed return value of Java_java_nio_channels_FileChannelImpl_size(), 
> Java_java_nio_channels_FileChannelImpl_implPosition__()

This breaks the build:

gcc -DHAVE_CONFIG_H -I. -I../../../../classpath/native/jni/java-nio 
-I../../../include -I. -I../../../../classpath/native/target/Linux 
-I../../../../classpath/native/target/generic 
-I../../../../classpath/native/jni/classpath -I../../../../classpath/include 
-I../../../include -g -Wall -MT java_nio_FileChannelImpl.lo -MD -MP -MF 
.deps/java_nio_FileChannelImpl.Tpo -c 
../../../../classpath/native/jni/java-nio/java_nio_FileChannelImpl.c  -fPIC 
-DPIC -o 
java_nio_FileChannelImpl.lo../../../../classpath/native/jni/java-nio/java_nio_FileChannelImpl.c:
 In function `Java_java_nio_channels_FileChannelImpl_size':
../../../../classpath/native/jni/java-nio/java_nio_FileChannelImpl.c:52: error:
`TARGET_NATIVE_MATH_INT_INT64_CONST_0' undeclared (first use in this function)
../../../../classpath/native/jni/java-nio/java_nio_FileChannelImpl.c:52: error:
(Each undeclared identifier is reported only once
../../../../classpath/native/jni/java-nio/java_nio_FileChannelImpl.c:52: error:
for each function it appears in.)

Please fix ASAP and check that things that you check in actually compile
with a clean tree (especially just before a release).

And please check in the ChangeLog file at the same time you check in the
file(s) you change.

Cheers,

Mark