Re: FYI: Patch: fixing warnings all over

[Michael Koch]

On Fri, Jan 09, 2004 at 03:02:19PM +0530, Ranjit Mathew wrote:
> Michael Koch wrote:
> > -  static final int WIND_EVEN_ODD = 0;
> > +  int WIND_EVEN_ODD = 0;
> 
> What's the rationale here (and at similar changes)?
> 
> 
> > -  public boolean isLoggable(LogRecord record);
> > +  boolean isLoggable(LogRecord record);
> 
> ...and here?
> 
> Sorry for being thick.

The rationale is that in interfaces all variables are "public static
final" and all methods are "public" by design. Our Coding Style says
that we avoid redundant modifiers because they are already there
implicitely.


Michael