commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: configure.ac problem


From: Archie Cobbs
Subject: Re: configure.ac problem
Date: Thu, 25 Mar 2004 13:24:54 -0600 (CST)

Tom Tromey wrote:
> >> if expr match ${target_cpu} .*86 > /dev/null; then target_cpu=x86;
> 
> Michael> Can we please make sure we need this stuff at all with latest
> Michael> autoconf ?  I'm not really sure about it. Why was this hack
> Michael> needed ? I dont see any documentation about this.
> 
> A comment would be nice.  Archie, could you add that before you commit?
> I assume this code is needed because target_cpu might be i686, i386,
> etc, but we just want "x86" as the name.

Below is my patch... note that this one is simpler, I just replaced
the "match" keyword with ":" which apparently is more portable.

-Archie

__________________________________________________________________________
Archie Cobbs      *        CTO, Awarix        *      http://www.awarix.com

Index: configure.ac
===================================================================
RCS file: /cvsroot/classpath/classpath/configure.ac,v
retrieving revision 1.10
diff -u -r1.10 configure.ac
--- configure.ac        13 Mar 2004 03:07:54 -0000      1.10
+++ configure.ac        25 Mar 2004 19:22:25 -0000
@@ -8,7 +8,9 @@
 AC_CONFIG_SRCDIR(java/lang/System.java)
 
 AC_CANONICAL_TARGET
-if expr match ${target_cpu} .*86 > /dev/null; then target_cpu=x86; fi
+
+dnl Fold all IA-32 CPU architectures into "x86"
+if expr ${target_cpu} : .*86 > /dev/null; then target_cpu=x86; fi
 
 dnl We will not track/change lib version until we reach version 1.0
 dnl at which time we'll have to be more anal about such things




reply via email to

[Prev in Thread] Current Thread [Next in Thread]