|
From: | Etienne Gagnon |
Subject: | Re: GNU indent for C code |
Date: | Sun, 28 Mar 2004 19:03:25 -0500 |
User-agent: | Mozilla/5.0 (X11; U; Linux ppc; en-US; rv:1.6) Gecko/20040314 Debian/1.6-3 |
Etienne Gagnon wrote:
Mark Wielaard wrote:I disagree. You can simply apply GNU Indent to the upstream code and compareIn this particular case there are two unfortunate things: - The native/fdlibm library isn't actually part of GNU Classpath, but a upstream library we use. This isn't clearly documented, I have put it on my list. In this case I think reverting it is the right thing to do. It makes diffs with the original library easier.the diffs to the result.
OK, to be fair, it can make "pushing" changes upstream a little more difficult, if one does not want to "reindent" GNU-style the whole modified function sent upstream. This begs quite a few questions: 1- Why is the fdlibm library source code in the Classpath repository at all? Shouldn't this library simply be a "static" or even "dynamic" library of Classpath? What the strong argument here, other than: "but we would have to tell users where to get it" ? 2- If 1- has a good motivation, why isn't there a vendor branch, to allow easy extraction of any improvement to send upstream? Etienne -- Etienne M. Gagnon, Ph.D. http://www.info.uqam.ca/~egagnon/ SableVM: http://www.sablevm.org/ SableCC: http://www.sablecc.org/
[Prev in Thread] | Current Thread | [Next in Thread] |