FYI: Fixlet for bug #8860 - check for null lock object

[Mark Wielaard]

Hi,

This is a fixlet for bug #8860 "new java.io.FilterWriter(null) should
throw NullPointerException" and a newly added mauve test to check for
null lock objects of Writers.

2004-05-14  Mark Wielaard  <address@hidden>
  
       * java/io/Writer.java (Writer(Object)): Check for null lock object.

This fixes the two relevant Mauve tests and gives no new regressions.
Committed.

Cheers,

Mark

--- java/io/Writer.java 8 Apr 2004 15:04:37 -0000       1.11
+++ java/io/Writer.java 16 May 2004 09:27:52 -0000
@@ -1,5 +1,5 @@
 /* Writer.java -- Base class for character output streams
-   Copyright (C) 1998, 1999, 2001, 2003 Free Software Foundation, Inc.
+   Copyright (C) 1998, 1999, 2001, 2003, 2004 Free Software Foundation, Inc.
  
 This file is part of GNU Classpath.
  
@@ -76,10 +76,13 @@
    * on the specified <code>Object</code>.
    *
    * @param lock The <code>Object</code> to use for synchronizing critical
-   *             sections
+   *             sections. Must be not be null.
    */
   protected Writer(Object lock)
   {
+    if (lock == null)
+      throw new NullPointerException();
+
     this.lock = lock;
   }

signature.asc
Description: This is a digitally signed message part