RE: Patch: more protocol fun in URL

[Jeroen Frijters]

Mark Wielaard wrote:
> On Sun, 2004-07-04 at 06:46, Mohan Embar wrote:
> > While we're on the subject of URL-related fun, does
> > anyone have anything to say about this equally fun patch?:
> > 
> > http://gcc.gnu.org/ml/java-patches/2004-q2/msg00843.html
> > 
> > I forwarded this on to the Classpath folks, as Tom suggested,
> > and can only assume that the non-response is due to the
> > jaw-dropping awe that's left them totally speechless after
> > looking at it....
> 
> Sorry for the silence. The patch looks sane to me.
> But I was hoping Jeroen could say something about it since it 
> looked to me he should also have seen this kind of failures
> with ikvm on the windows platform. Jeroen, what is your opinion?

To be honest I didn't look too closely at it originally. Sending bz2
attachments is not a good way to get my attention ;-)

However, I just looked at the test case and it works fine on IKVM (both
on Linux and on Windows). Also, since file comes from the passed in URL,
can't we assume that it already is in the correct format?

So, as it stands, I'd like to see more evidence that this patch is
correct, before committing it.

Regards,
Jeroen