Re: http.agent patch

[Michael Koch]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Sonntag, 11. Juli 2004 22:47 schrieb Mark Wielaard:
> Hi,
>
> Both Tom and Michael had some comments on my last patch to set the
> http agent for HTTP connections. I believe the following patch
> addresses both concerns and makes sure that even when the
> Connection class is loaded/initialized from a class with not enough
> permissions it can still get at the necessary system properties.
>
> 2004-07-11  Mark Wielaard  <address@hidden>
>
>         * java/lang/System.java (static): Set http.agent system
> property when not yet set.
>         * gnu/java/net/protocol/http/Connection.java (static): Get
> httpAgent from system property inside
> AccessController.doPrivileged() call.
>
> Sorry for not handling this before 0.10 got released.
> OK to commit?

I like it. I just don't get why you remove the "private" here:

- -  private static int proxyPort = 80;
- -  private static boolean proxyInUse = false;
- -  private static String proxyHost = null;
- -
- -  private static final String userAgent;
+  
+  // Properties depeending on system properties settings
+  static int proxyPort = 80;
+  static boolean proxyInUse = false;
+  static String proxyHost = null;
+  static String userAgent;

Perhaps to much beer today ...


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFA8aoGWSOgCCdjSDsRAujzAKCMYOeahw7VwVwERWtZ0S/gsgYshwCgnMR/
cUBp0x8Twgzf/nODy9w3adU=
=gq1F
-----END PGP SIGNATURE-----