commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patch: java.io.ObjectOutputStream


From: Mark Wielaard
Subject: Re: Patch: java.io.ObjectOutputStream
Date: Sun, 18 Jul 2004 16:48:25 +0200

Hi,

On Thu, 2004-07-15 at 14:17, Michael Koch wrote:

> I commited the attached patch to merge java.io.ObjectOutputStream with 
> libgcj again.
> 
>
> 2004-07-15  Andrew Haley  <address@hidden>
> 
>       * java/io/ObjectOutputStream.java: Add DEBUG statements
>       everywhere.
>       (dumpElementln): New method.
>       (depth): New field.

Which is nice.
But this also adds:

> @@ -318,6 +333,8 @@
>  
>             if (obj instanceof Serializable)
>               {
> +               Object prevObject = this.currentObject;
> +               ObjectStreamClass prevObjectStreamClass = 
> this.currentObjectStreamClass;
>                 currentObject = obj;
>                 ObjectStreamClass[] hierarchy =
>                   ObjectStreamClass.getObjectStreamClasses(clazz);

> [...]
 
> -               currentObject = null;
> -               currentObjectStreamClass = null;
> +               this.currentObject = prevObject;
> +               this.currentObjectStreamClass = prevObjectStreamClass;
>                 currentPutField = null;
>                 break;
>               }

If this was intended then this should also be mentioned in the
ChangeLog. Could you see if this was also in the original patch that
Andrew made to libgcj?

Thanks,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part


reply via email to

[Prev in Thread] Current Thread [Next in Thread]