[commit-cp] [bugs #9946] gnu/java/security/util/Prime.java ignores return value of BigInteger methods

[Tom Tromey]

This mail is an automated notification from the bugs tracker
 of the project: classpath.

/**************************************************************************/
[bugs #9946] Latest Modifications:

Changes by: 
                Tom Tromey <address@hidden>
'Date: 
                Tue 08/17/2004 at 03:09 (America/Denver)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Fixed
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
I've checked in the fix.







/**************************************************************************/
[bugs #9946] Full Item Snapshot:

URL: <http://savannah.gnu.org/bugs/?func=detailitem&item_id=9946>
Project: classpath
Submitted by: 0
On: Mon 08/09/2004 at 21:15

Category:  None
Severity:  5 - Average
Resolution:  Fixed
Assigned to:  None
Status:  Closed
Platform Version:  None


Summary:  gnu/java/security/util/Prime.java ignores return value of BigInteger 
methods

Original Submission:  At 4 places in gnu/java/security/util/Prime.java, add is 
called on a BigInteger as though it mutates the BigInteger it is invoked on 
(lines 58, 63, 79 and 125). 

BigInteger is immutable. Thus, methods such as BigInteger.add return a new 
BigInteger, rather than mutating the BigInteger they are applied to. 

This bug was found with our static analysis tool for finding bugs in Java 
programs, FindBugs:
   http://findbugs.sourceforge.net/


Follow-up Comments
------------------


-------------------------------------------------------
Date: Tue 08/17/2004 at 03:09       By: tromey
I've checked in the fix.













For detailed info, follow this link:
<http://savannah.gnu.org/bugs/?func=detailitem&item_id=9946>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/