[commit-cp] [patch #3614] DefaultTableModel - fixes and Javadocs

[Michael Koch]

This mail is an automated notification from the patch tracker
 of the project: classpath.

/**************************************************************************/
[patch #3614] Latest Modifications:

Changes by: 
                Michael Koch <address@hidden>
'Date: 
                Fre 07.01.2005 at 22:20 (GMT)

            What     | Removed                   | Added
---------------------------------------------------------------------------
          Resolution | None                      | Applied
              Status | Open                      | Closed


------------------ Additional Follow-up Comments ----------------------------
This patch is now commited to CVS and will be in GNU classpath 0.14.






/**************************************************************************/
[patch #3614] Full Item Snapshot:

URL: <http://savannah.gnu.org/patch/?func=detailitem&item_id=3614>
Project: classpath
Submitted by: David Gilbert
On: Die 04.01.2005 at 21:57

Category:  None
Priority:  1 - Later
Resolution:  Applied
Privacy:  Public
Assigned to:  None
Originator Email:  
Status:  Closed


Summary:  DefaultTableModel - fixes and Javadocs

Original Submission:  This patch fixes assorted problems with the 
DefaultTableModel class (Mauve tests will be committed shortly) and adds 
Javadocs to the class (and also the TableModel interface).  Changelog entry is:

2005-01-04  David Gilbert  <address@hidden>

        * javax/swing/table/DefaultTableModel.java
        (DefaultTableModel()): Added Javadocs.
        (DefaultTableModel(int, int)): Fixed implementation.
        (DefaultTableModel(Vector, int)): Throw IllegalArgumentException
        for negative rowCount.
        (DefaultTableModel(Object[], int)): Added Javadocs.
        (DefaultTableModel(Vector, Vector)): Likewise.
        (DefaultTableModel(Object[][], Object[])): Likewise.
        (getDataVector): Likewise.
        (setDataVector(Vector, Vector)): Likewise.
        (setDataVector(Object[][], Object[])): Likewise.
        (newDataAvailable): Likewise.
        (newRowsAdded): Likewise.
        (rowsRemoved): Likewise.
        (setColumnIdentifiers(Vector)): Allow for null argument.
        (setColumnIdentifiers(Object[])): Added Javadocs.
        (setNumRows): Likewise.
        (setRowCount): Adds new rows if necessary, and sends more specific
        TableModelEvent.
        (setColumnCount): Allow for null columnIdentifiers.
        (addColumn(Object)): Added Javadocs.
        (addColumn(Object, Vector)): Handle null columnData.
        (addColumn(Object, Object[])): Handle columnData with more or less
        entries than rows in the table.
        (addRow(Vector)): Fire appropriate event.
        (addRow(Object[])): Added Javadocs.
        (insertRow(int, Vector)): Fire appropriate event.
        (insertRow(int, Object[])): Added Javadocs.
        (moveRow): Reimplemented.
        (removeRow(int)): Fire appropriate event.
        (getColumnCount): Allow for null columnIdentifiers.
        (getColumnName): Now returns empty string when column index is too
        large.
        (isCellEditable): Added Javadocs.
        (getValueAt): Likewise.
        (setValueAt): Fire more specific event.
        (convertToVector): Added Javadocs.
        * javax/swing/table/TableModel.java
        Added Javadocs.

Follow-up Comments
------------------


-------------------------------------------------------
Date: Fre 07.01.2005 at 22:20       By: Michael Koch <mkoch>
This patch is now commited to CVS and will be in GNU classpath 0.14.

-------------------------------------------------------
Date: Don 06.01.2005 at 19:02       By: 0 <None>
I looked into this patch and it looks very good. I made few minor changes to 
replace fileTableChanged(new TableModelEvent(...)) calls to
call methods already implemented in AbstractTableModel.

i.e.
< +    fireTableCellUpdated(row,column);
---
> +    fireTableChanged(
> +      new TableModelEvent(this, row, row, column, TableModelEvent.UPDATE)
> +    ); 

This patch is now committed to java-gui-branch

-------------------------------------------------------
Date: Mit 05.01.2005 at 10:17       By: David Gilbert <trebligd>
OK, thanks!  The Mauve tests that drive the changes I made in the attached 
patch have now been committed to Mauve CVS.

-------------------------------------------------------
Date: Die 04.01.2005 at 22:09       By: Michael Koch <mkoch>
Patch forwarded to Olga as she works on this since a longer time already and 
surely knows more about it.






File Attachments
-------------------

-------------------------------------------------------
Date: Die 04.01.2005 at 21:57  Name: patch.txt  Size: 23,87KB   By: trebligd

http://savannah.gnu.org/patch/download.php?item_id=3614&amp;item_file_id=3995






For detailed info, follow this link:
<http://savannah.gnu.org/patch/?func=detailitem&item_id=3614>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/