commit-classpath
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[commit-cp] [bug #13267] gnu.java.nio.charset.iconv.IconvProvider: the c


From: Ito Kazumitsu
Subject: [commit-cp] [bug #13267] gnu.java.nio.charset.iconv.IconvProvider: the constructor must be public
Date: Sun, 5 Jun 2005 22:28:57 +0000
User-agent: w3m/0.5.1

Follow-up Comment #1, bug #13267 (project classpath):

This is the patch applied in Kaffe.

ChangeLog:

2005-06-05  Ito Kazumitsu  <address@hidden>

        * libraries/javalib/gnu/java/nio/charset/iconv/IconvProvider.java
        (IconvProvider): Made the constructor public.



--- gnu/java/nio/charset/iconv/IconvProvider.java.orig  Mon Apr 18 20:35:14
2005
+++ gnu/java/nio/charset/iconv/IconvProvider.java       Sun Jun  5 10:53:41 2005
@@ -62,7 +62,11 @@
         }
     }
 
-  private IconvProvider()
+  // Declaring the construtor public may violate the use of singleton.
+  // But it must be public so that an instance of this class can be
+  // created by Class.newInstance(), which is the case when this provider
is
+  // defined in META-INF/services/java.nio.charset.spi.CharsetProvider.
+  public IconvProvider()
   {
     IconvMetaData.setup();
   }



    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?func=detailitem&item_id=13267>

_______________________________________________
  Message sent via/by Savannah
  http://savannah.gnu.org/





reply via email to

[Prev in Thread] Current Thread [Next in Thread]