[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Commit-gnuradio] [gnuradio] 02/07: float internally, double in API: Hon
From: |
git |
Subject: |
[Commit-gnuradio] [gnuradio] 02/07: float internally, double in API: Honest signatures for honest people |
Date: |
Mon, 6 Jul 2015 23:37:00 +0000 (UTC) |
This is an automated email from the git hooks/post-receive script.
jcorgan pushed a commit to branch master
in repository gnuradio.
commit 3d4c7424595687b0dd4bd4d6ca72c215d5b0606c
Author: Marcus Müller <address@hidden>
Date: Tue Jun 30 12:36:29 2015 +0200
float internally, double in API: Honest signatures for honest people
I can see why the API preferred to have double (for later implementation
changes). No one complained, so accuracy is probably sufficient. Time to
be honest about the signature.
---
gr-analog/include/gnuradio/analog/frequency_modulator_fc.h | 2 +-
gr-analog/lib/frequency_modulator_fc_impl.cc | 4 ++--
gr-analog/lib/frequency_modulator_fc_impl.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gr-analog/include/gnuradio/analog/frequency_modulator_fc.h
b/gr-analog/include/gnuradio/analog/frequency_modulator_fc.h
index c573efe..8388310 100644
--- a/gr-analog/include/gnuradio/analog/frequency_modulator_fc.h
+++ b/gr-analog/include/gnuradio/analog/frequency_modulator_fc.h
@@ -47,7 +47,7 @@ namespace gr {
*
* \param sensitivity radians/sample = amplitude * sensitivity
*/
- static sptr make(double sensitivity);
+ static sptr make(float sensitivity);
virtual void set_sensitivity(float sens) = 0;
virtual float sensitivity() const = 0;
diff --git a/gr-analog/lib/frequency_modulator_fc_impl.cc
b/gr-analog/lib/frequency_modulator_fc_impl.cc
index 5015ff7..1158167 100644
--- a/gr-analog/lib/frequency_modulator_fc_impl.cc
+++ b/gr-analog/lib/frequency_modulator_fc_impl.cc
@@ -34,13 +34,13 @@ namespace gr {
namespace analog {
frequency_modulator_fc::sptr
- frequency_modulator_fc::make(double sensitivity)
+ frequency_modulator_fc::make(float sensitivity)
{
return gnuradio::get_initial_sptr
(new frequency_modulator_fc_impl(sensitivity));
}
- frequency_modulator_fc_impl::frequency_modulator_fc_impl(double
sensitivity)
+ frequency_modulator_fc_impl::frequency_modulator_fc_impl(float sensitivity)
: sync_block("frequency_modulator_fc",
io_signature::make(1, 1, sizeof(float)),
io_signature::make(1, 1, sizeof(gr_complex))),
diff --git a/gr-analog/lib/frequency_modulator_fc_impl.h
b/gr-analog/lib/frequency_modulator_fc_impl.h
index d2c57b3..9f5310c 100644
--- a/gr-analog/lib/frequency_modulator_fc_impl.h
+++ b/gr-analog/lib/frequency_modulator_fc_impl.h
@@ -35,7 +35,7 @@ namespace gr {
float d_phase;
public:
- frequency_modulator_fc_impl(double sensitivity);
+ frequency_modulator_fc_impl(float sensitivity);
~frequency_modulator_fc_impl();
void set_sensitivity(float sens) { d_sensitivity = sens; }
- [Commit-gnuradio] [gnuradio] branch master updated (b9bdd1c -> 1185d40), git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 05/07: Merge branch 'maint', git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 04/07: Merge remote-tracking branch 'mbr0wn/python/eng_args', git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 03/07: Merge branch 'maint', git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 06/07: Merge remote-tracking branch 'mmueller/freq_phase_mod_honest_signatures', git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 07/07: Merge branch 'maint', git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 01/07: base: Added argparse equivalent for eng_option, git, 2015/07/06
- [Commit-gnuradio] [gnuradio] 02/07: float internally, double in API: Honest signatures for honest people,
git <=