[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[hurd] 04/26: Revert "tmpfs: drop privileges in the tmpfs translator"
From: |
Samuel Thibault |
Subject: |
[hurd] 04/26: Revert "tmpfs: drop privileges in the tmpfs translator" |
Date: |
Sat, 02 Nov 2013 14:44:43 +0000 |
This is an automated email from the git hooks/post-receive script.
sthibault pushed a commit to branch upstream
in repository hurd.
commit 0fd357b48642f16c3adf8ed474f299daecef2613
Author: Justus Winter <address@hidden>
Date: Tue Oct 8 15:49:02 2013 +0200
Revert "tmpfs: drop privileges in the tmpfs translator"
This reverts commit 7075bc11289355478659cd1610632a9299734afc.
Dropping the unix privileges of the tmpfs translator causes problems
with the passive translator startup. The function fshelp_fetch_root
creates an auth handle containing the processes original UID and
GID. But if the privileges were dropped before, this operation fails
with EPERM.
This commit also broke mkfifo(3), possibly for similar or related
reasons.
* tmpfs/tmpfs.c (main): Do not drop all privileges.
---
tmpfs/tmpfs.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/tmpfs/tmpfs.c b/tmpfs/tmpfs.c
index 1872a7d..7da3dd5 100644
--- a/tmpfs/tmpfs.c
+++ b/tmpfs/tmpfs.c
@@ -29,7 +29,6 @@ the Free Software Foundation, 675 Mass Ave, Cambridge, MA
02139, USA. */
#include <fcntl.h>
#include <hurd.h>
#include <hurd/paths.h>
-#include <nullauth.h>
char *diskfs_server_name = "tmpfs";
char *diskfs_server_version = HURD_VERSION;
@@ -438,11 +437,6 @@ main (int argc, char **argv)
/* We must keep the REALNODE send right to remain the active
translator for the underlying node. */
- /* Drop all privileges. */
- err = setnullauth();
- if (err)
- error (1, err, "Could not drop privileges");
-
pthread_mutex_unlock (&diskfs_root_node->lock);
/* and so we die, leaving others to do the real work. */
--
Alioth's /usr/local/bin/git-commit-notice on
/srv/git.debian.org/git/pkg-hurd/hurd.git
- [hurd] branch upstream updated (223b7da -> 90b039d), Samuel Thibault, 2013/11/02
- [hurd] 01/26: Check for negative sizes in file_set_size, Samuel Thibault, 2013/11/02
- [hurd] 03/26: Fix memory leak in exec, Samuel Thibault, 2013/11/02
- [hurd] 02/26: Fix memory leak in libnetfs, Samuel Thibault, 2013/11/02
- [hurd] 10/26: console-client: minor stylistic fix, Samuel Thibault, 2013/11/02
- [hurd] 04/26: Revert "tmpfs: drop privileges in the tmpfs translator",
Samuel Thibault <=
- [hurd] 26/26: Merge remote-tracking branch 'upstream/master' into upstream, Samuel Thibault, 2013/11/02
- [hurd] 09/26: console-client: fix error handling, Samuel Thibault, 2013/11/02
- [hurd] 11/26: console-client: replace function epilogue with console_exit, Samuel Thibault, 2013/11/02
- [hurd] 24/26: Fix use after free, Samuel Thibault, 2013/11/02
- [hurd] 12/26: term: fix read on a closed PTY, Samuel Thibault, 2013/11/02
- [hurd] 23/26: libshouldbeinlibc: fix error handling in maptime_map, Samuel Thibault, 2013/11/02
- [hurd] 05/26: trans: rename a global variable, Samuel Thibault, 2013/11/02
- [hurd] 07/26: console-client: remove the pid file on clean exits, Samuel Thibault, 2013/11/02
- [hurd] 08/26: console-client: entitle console_exit with the noreturn attribute, Samuel Thibault, 2013/11/02
- [hurd] 06/26: libfshelp: properly free active translator entries, Samuel Thibault, 2013/11/02