commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 38/98: init: fix port leak


From: Samuel Thibault
Subject: [hurd] 38/98: init: fix port leak
Date: Tue, 14 Jan 2014 02:00:00 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch upstream
in repository hurd.

commit 78636c03a561d3a9a1b7c008dc390fe854196309
Author: Justus Winter <address@hidden>
Date:   Mon Nov 25 13:05:01 2013 +0100

    init: fix port leak
    
    * init/init.c (S_startup_essential_task): Fix port leak.
---
 init/init.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/init/init.c b/init/init.c
index de5dd6b..b7b40bd 100644
--- a/init/init.c
+++ b/init/init.c
@@ -1202,6 +1202,10 @@ S_startup_essential_task (mach_port_t server,
   static int authinit, procinit, execinit;
   int fail;
 
+  /* Always deallocate the extra reference this message carries.  */
+  if (MACH_PORT_VALID (credential))
+    mach_port_deallocate (mach_task_self (), credential);
+
   if (credential != host_priv)
     return EPERM;
 
@@ -1209,8 +1213,6 @@ S_startup_essential_task (mach_port_t server,
   if (fail)
     return fail;
 
-  mach_port_deallocate (mach_task_self (), credential);
-
   if (!booted)
     {
       if (!strcmp (name, "auth"))

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]