commit-hurd
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[hurd] 10/98: auth: fix use of uninitialized variable err


From: Samuel Thibault
Subject: [hurd] 10/98: auth: fix use of uninitialized variable err
Date: Tue, 14 Jan 2014 01:59:58 +0000

This is an automated email from the git hooks/post-receive script.

sthibault pushed a commit to branch upstream
in repository hurd.

commit bd55e5ccce4b35ffb1028d7810b93df3b7522d05
Author: Justus Winter <address@hidden>
Date:   Wed Nov 6 16:17:26 2013 +0100

    auth: fix use of uninitialized variable err
    
    Previously a plausible execution path existed so the value of err was
    undefined at the end of the function, making the function return
    arbitrary error values. Fix this by initializing it to 0.
    
    Found using the Clang Static Analyzer.
    
    * auth/auth.c (S_auth_server_authenticate): Initialize err to 0.
---
 auth/auth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/auth/auth.c b/auth/auth.c
index 167d8f0..91a21e4 100644
--- a/auth/auth.c
+++ b/auth/auth.c
@@ -381,7 +381,7 @@ S_auth_server_authenticate (struct authhandle *serverauth,
 {
   struct pending_user *u;
   struct authhandle *user;
-  error_t err;
+  error_t err = 0;
 
   if (! serverauth)
     return EOPNOTSUPP;

-- 
Alioth's /usr/local/bin/git-commit-notice on 
/srv/git.debian.org/git/pkg-hurd/hurd.git



reply via email to

[Prev in Thread] Current Thread [Next in Thread]