[commit-womb] gnumaint gm

[Karl Berry]

CVSROOT:        /sources/womb
Module name:    gnumaint
Changes by:     Karl Berry <karl>       07/05/12 23:11:46

Modified files:
        .              : gm 

Log message:
        enable tests, skip blank entries.

CVSWeb URLs:
http://cvs.savannah.gnu.org/viewcvs/gnumaint/gm?cvsroot=womb&r1=1.1&r2=1.2

Patches:
Index: gm
===================================================================
RCS file: /sources/womb/gnumaint/gm,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -b -r1.1 -r1.2
--- gm  10 May 2007 01:28:27 -0000      1.1
+++ gm  12 May 2007 23:11:45 -0000      1.2
@@ -1,5 +1,5 @@
 #!/usr/bin/env perl
-# $Id: gm,v 1.1 2007/05/10 01:28:27 karl Exp $
+# $Id: gm,v 1.2 2007/05/12 23:11:45 karl Exp $
 # Report packages whose maintainer has not responded.
 
 $DEBUG = 0;
@@ -30,14 +30,14 @@
   for my $p (sort { lc($a) cmp lc($b) } keys %pkgs) {
     #&debug_hash ("$p", $pkgs{$p});
 
-    if (0 && grep { $p eq $_ } @recentrel) {
+    if (grep { $p eq $_ } @recentrel) {
       &debug ("$p recently released, skipping");
 
-    } elsif (0 && exists $activity{$p}) {
+    } elsif (exists $activity{$p}) {
       # xx have to only check back to a certain date eventually
       &debug ("$p got activity reply, skipping");
 
-    } elsif (0 && $pkgs{$p}->{"name"} eq "unmaintained") {
+    } elsif ($pkgs{$p}->{"name"} eq "unmaintained") {
       # xx have to only check back to a certain date eventually
       &debug ("$p unmaintained, skipping");
 
@@ -71,9 +71,11 @@
   my %maint;
   while (<MAINTAINERS_FILE>) {
     chomp;
+    next if /^#/;  # ignore comments
     
     # at a blank line, save the maintainer info we've accumulated, if any.
     if (/^\s*$/) {
+      &debug_hash ($., %maint);
       if (keys %maint) {
         if ($how eq "by-package") {
           # split apart package field.
@@ -100,6 +102,7 @@
         undef %maint;  # clear out for next maintainer.
       }
       last if /^\f$/;  # form feed marks end of info.
+      next;
     }
 
     # key is everything before the first colon.
@@ -114,7 +117,7 @@
   }
   
   # skip the rest.
-  close (MAINTAINERS_FILE) || warn "close($MAINTAINERS) failed: $!";
+  close (MAINTAINERS_FILE) || warn "close($MAINTAINERS_FILE) failed: $!";
   
   return %ret;
 }
@@ -144,7 +147,7 @@
       die "can't read_activity($how)";
     }
   }
-  close (ACTIVITY_FILE) || warn "close($ACTIVITY) failed: $!";
+  close (ACTIVITY_FILE) || warn "close($ACTIVITY_FILE) failed: $!";
   
   return %ret;
 }
@@ -156,16 +159,16 @@
 # 
 sub read_recentrel
 {
-  my @ret;
+  my @ret = ();
   
   open (RECENTREL_FILE) || die "open($RECENTREL_FILE) failed: $!";
   while (<RECENTREL_FILE>) {
     next if /^\s*#/;  # ignore comments
     next if /^\s*$/;  # ignore blank lines.
     chomp;
-    push (@ret, @_)
+    push (@ret, $_);
   }
-  close (RECENTREL_FILE) || warn "close($RECENTREL) failed: $!";
+  close (RECENTREL_FILE) || warn "close($RECENTREL_FILE) failed: $!";
  
   return @ret;
 }