[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing
From: |
Ben Elliston |
Subject: |
Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor |
Date: |
Mon, 20 Aug 2018 14:34:33 +1000 |
User-agent: |
Mutt/1.9.4 (2018-02-28) |
On Tue, Aug 14, 2018 at 01:53:37PM -0400, John Ericson wrote:
> Message-Id: <address@hidden>
> From: John Ericson <address@hidden>
> Date: Tue, 14 Aug 2018 13:25:58 -0400
> Subject: [PATCH 1/2] * testsuite/config-sub.data: Add legacy test cases
> To: address@hidden
This is a bit weird:
> @@ -140,8 +142,13 @@ dec3100
> mips-dec-ultrix4.2
> decstation mips-dec-ultrix4.2
> decstation-3100 mips-dec-ultrix4.2
> decstatn mips-dec-ultrix4.2
> +decsystem10* pdp10-dec-tops10
> +dec10* pdp10-dec-tops10
> +decsystem20* pdp10-dec-tops20
> +dec20* pdp10-dec-tops20
> dicos i686-pc-dicos
Why are you adding test cases with asterisks in them? Looks like too
much copying and pasting?
Also, the revised testsuite does not pass:
Invalid configuration `crx-unknown-elf': machine `crx-unknown' not recognized
FAIL: crx-unknown-elf -> , but crx-unknown-elf should map to itself
Please remove the failing tests until you submit a patch that fixes
the problem (and the test case can accompany that patch).
Thanks,
Ben
signature.asc
Description: PGP signature
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, (continued)
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, Ben Elliston, 2018/08/12
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/12
- Message not available
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, Ben Elliston, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, Ben Elliston, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, Ben Elliston, 2018/08/13
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/14
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/14
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor,
Ben Elliston <=
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/20
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, Ben Elliston, 2018/08/20
- Re: [PATCH] * config.sub: Deduplicate `basic_machine` by always allowing the vendor, John Ericson, 2018/08/20
- Message not available
- Re: [PATCH] * config.sub: Deduplicate and clean `basic_machine` checks, Ben Elliston, 2018/08/22