[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [coreutils] [PATCH] sort: -h now handles comparisons such as 6000K v
|
From: |
Pádraig Brady |
|
Subject: |
Re: [coreutils] [PATCH] sort: -h now handles comparisons such as 6000K vs 5M and 5MiB vs 5MB |
|
Date: |
Fri, 30 Jul 2010 22:34:16 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 |
On 30/07/10 18:25, Paul Eggert wrote:
> On 07/30/10 05:06, Pádraig Brady wrote:
>> Perhaps since strtold() is so heavy weight anyway,
>> we could strip commas first?
>
> Yes, that's easily doable; I'll look into that soon.
>
> By the way, my ulterior motive for doing this patch is
> to fix up the rat's nest of code buried deeply inside
> the core comparison operations. In particular, compare()
> is deliberately called on the same line, only for debugging
> purposes: this is deeply weird and inhibits some further
> optimizations that I have in mind.
Heh, and there was me thinking it was an elegant way
to ensure none of the comparison operations were shortcuted
while minimizing testing of the debug flag :)
> Fixing this is also
> on my list of things to do, but I'll put the strtold stuff
> higher up than that.
great thanks!
Pádraig.