[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 09/22] build: add an explicative comment
From: |
Stefano Lattarini |
Subject: |
[PATCH 09/22] build: add an explicative comment |
Date: |
Wed, 29 Aug 2012 23:54:46 +0200 |
* man/Makefile.am (EXTRA_DIST): Here, portability issues of the
employed idiom. Reformat the definition a little while at it.
Signed-off-by: Stefano Lattarini <address@hidden>
---
man/Makefile.am | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/man/Makefile.am b/man/Makefile.am
index 8e9df08..44eb310 100644
--- a/man/Makefile.am
+++ b/man/Makefile.am
@@ -19,10 +19,19 @@ dist_man1_MANS = $(MAN)
man_aux = $(dist_man1_MANS:.1=.x)
-EXTRA_DIST = $(man_aux) $(NO_INSTALL_PROGS_DEFAULT:%=%.x) help2man \
- $(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+EXTRA_DIST = $(man_aux) help2man
MAINTAINERCLEANFILES = $(dist_man1_MANS)
+# The "$(VAR:%=%.x)" idiom is not portable according to POSIX, but in
+# practice it works with several make implementation (GNU, BSD, CCS make
+# from Solaris 10, Sun distributed make). In addition, since only
+# maintainers are expected to build release tarballs (and they should
+# use GNU make when doing so), it's not big deal if this won't work with
+# some dumber make implementation.
+EXTRA_DIST += \
+ $(NO_INSTALL_PROGS_DEFAULT:%=%.x) \
+ $(NO_INSTALL_PROGS_DEFAULT:%=%.1)
+
# Depend on ../.version to get version number changes.
common_dep = ../.version
--
1.7.12
- [PATCH 00/22] Towards a non-recursive build system for coreutils?, Stefano Lattarini, 2012/08/29
- [PATCH 02/22] maint: slightly improve .gitignore, Stefano Lattarini, 2012/08/29
- [PATCH 01/22] build: don't abuse Automake internals (with its 'check-am' rule), Stefano Lattarini, 2012/08/29
- [PATCH 03/22] build: add extra *.texi files to coreutils_TEXINFOS, not EXTRA_DIST, Stefano Lattarini, 2012/08/29
- [PATCH 04/22] build: prefer '$(top_srcdir)/doc' over '$(srcdir)' in doc Makefile, Stefano Lattarini, 2012/08/29
- [PATCH 05/22] build: use 'check-local' to extend the 'check' target, Stefano Lattarini, 2012/08/29
- [PATCH 06/22] build: don't use recursive make to build the 'doc' subdirectory, Stefano Lattarini, 2012/08/29
- [PATCH 09/22] build: add an explicative comment,
Stefano Lattarini <=
- [PATCH 07/22] build: don't define $(SUFFIXES) explicitly, Stefano Lattarini, 2012/08/29
- [PATCH 08/22] maint: simplify definition of $MAN in configure.ac, Stefano Lattarini, 2012/08/29
- [PATCH 10/22] build: fix a stray usage of uninitialized $(ME), Stefano Lattarini, 2012/08/29
- [PATCH 12/22] maint: typofix: s/it's/its/, Stefano Lattarini, 2012/08/29
- [PATCH 11/22] build: rename common_dep -> mandep in man/Makefile, Stefano Lattarini, 2012/08/29
- [PATCH 14/22] build: make some rule less dependent of exact source tree layout, Stefano Lattarini, 2012/08/29
- [PATCH 13/22] build: rely on VPATH capabilities in man/Makefile, Stefano Lattarini, 2012/08/29
- [PATCH 15/22] build: convenience target 'all_programs' at top-level, Stefano Lattarini, 2012/08/29
- [PATCH 16/22] build: rework some recipes in main/Makefile.am, for future changes, Stefano Lattarini, 2012/08/29
- [PATCH 18/22] maint: move man-related syntax checks in cfg.mk, Stefano Lattarini, 2012/08/29