[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/7] build: require Automake >= 1.11.6
From: |
Jim Meyering |
Subject: |
Re: [PATCH 3/7] build: require Automake >= 1.11.6 |
Date: |
Fri, 31 Aug 2012 12:10:39 +0200 |
Bernhard Voelker wrote:
> On 08/31/2012 10:16 AM, Jim Meyering wrote:
>> wrote the commit log for you, too.
>> Here's the result. I'll wait for your ACK:
>
> Thanks for wrapping that into a patch.
>
> I just noticed that there's still a stray
>
> grep: *.1: No such file or directory
Well spotted.
> in the output. That comes from sc_option_desc_uppercase.
> What has changed re. the man files?
Here's the fix:
>From 56661fd87ad1bede1bb84cf3d36d410edd327301 Mon Sep 17 00:00:00 2001
From: Jim Meyering <address@hidden>
Date: Fri, 31 Aug 2012 12:08:49 +0200
Subject: [PATCH] build: reenable just-moved/broken syntax-check rule
* cfg.mk (sc_option_desc_uppercase): Now that this rule lives in cfg.mk,
we must search man/*.1, not "*.1".
Reported by Bernhard Voelker.
---
cfg.mk | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/cfg.mk b/cfg.mk
index 44a43f8..c945ea6 100644
--- a/cfg.mk
+++ b/cfg.mk
@@ -173,9 +173,8 @@ sc_long_lines:
ALL_RECURSIVE_TARGETS += sc_option_desc_uppercase
.PHONY: sc_option_desc_uppercase
sc_option_desc_uppercase:
- @grep '^\\fB\\-' -A1 *.1 | LC_ALL=C grep '\.1.[A-Z][a-z]' && \
- { echo 1>&2 '$@: found initial capitals in --help'; \
- exit 1; } || :;
+ @grep '^\\fB\\-' -A1 man/*.1 | LC_ALL=C grep '\.1.[A-Z][a-z]' \
+ && { echo 1>&2 '$@: found initial capitals in --help'; exit 1; } || :
sc_option_desc_uppercase: $(dist_man1_MANS) \
$(patsubst %,man/%.1,$(NO_INSTALL_PROGS_DEFAULT)) \
all_programs
--
1.7.12.146.g16d26b1
- [PATCH 7/7] tests: get rid of the 'shell-or-perl' auxiliary script, (continued)
- [PATCH 7/7] tests: get rid of the 'shell-or-perl' auxiliary script, Stefano Lattarini, 2012/08/30
- [PATCH 3/7] build: require Automake >= 1.11.6, Stefano Lattarini, 2012/08/30
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Jim Meyering, 2012/08/30
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Bernhard Voelker, 2012/08/30
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Jim Meyering, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Bernhard Voelker, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Stefano Lattarini, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Jim Meyering, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Bernhard Voelker, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6,
Jim Meyering <=
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Bernhard Voelker, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Erik Auerswald, 2012/08/31
- Re: [PATCH 3/7] build: require Automake >= 1.11.6, Jim Meyering, 2012/08/31
[PATCH 5/7] tests: detect missing perl at configure runtime, Stefano Lattarini, 2012/08/30
[PATCH 6/7] tests: add .sh and .pl suffixes to shell and perl tests, respectively, Stefano Lattarini, 2012/08/30