Re: Hide rootfs filesystem in df

[Bernhard Voelker]

CC'ed Philipp (because the patch is already
on the way to openSUSE:Factory).

On 11/29/2012 08:50 AM, Bernhard Voelker wrote:
> Hi Jim,
> 
> as Robert wrote, it's the easiest way to fix it.
> [...]
> So I'm 60:40 for adding it.

Unfortunately, it can't be added like this:

>>> +  if (STRNCMP_LIT (fstype, "rootfs") == 0)
>>> +    return;
>>> +

If fstype is NULL - which is the case e.g. for
"df --total" -,then STRNCMP_LIT dumps core.
The fix is to test fstype against NULL.

I'm still thinking about how to combine "hide rootfs"
with "hide duplicates" (from Ondrej), but I've not
found an elegant solution yet.

Have a nice day,
Berny