[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: tests/du/slink.sh: what's the rationale?
From: |
Bernhard Voelker |
Subject: |
Re: tests/du/slink.sh: what's the rationale? |
Date: |
Sun, 20 Jan 2013 23:55:09 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
On 01/20/2013 10:15 PM, Jim Meyering wrote:
> Pádraig Brady wrote:
>
>> On 01/20/2013 12:58 PM, Bernhard Voelker wrote:
>>> On 01/20/2013 01:34 PM, Pádraig Brady wrote:
>>>> On 01/20/2013 12:31 PM, Bernhard Voelker wrote:
>>>>> On 01/20/2013 12:01 PM, Pádraig Brady wrote:
>>>>>> On 01/19/2013 10:33 PM, Bernhard Voelker wrote:
>>>>>>> Is tests/du/slink.sh obsolete nowadays?
>>>>>
>>>>> That test is problematic with various file systems, and the original
>>>>> test case is already covered by other tests. I'd tend to simply
>>>>> remove it.
>>>>
>>>> +1
>
> For the record, it was trying to ensure that not all symlinks
> (across all file system types) have zero size.
>
> Removing that test sounds fine to me, too.
> FYI, here's the ChangeLog entry for the addition of that file:
>
> * tests/du/Makefile.am (TESTS): Add slink.
> * tests/du/slink: New test for system.h change of 2002-08-31.
>
> Which refers to this commit:
>
> commit 62808a7fb5cbb2d321719c0cba558f2ce8c90d24
Thank you both.
I amended the commit log with the above information before pushing:
http://git.sv.gnu.org/cgit/coreutils.git/commit/?id=40b2770a
Have a nice day,
Berny