Re: [PATCH 2/6] ls: correct document about its security context label

[Yang Chengwei]

On Thu, Jan 16, 2014 at 12:19:05PM +0000, Pádraig Brady wrote:
> On 01/16/2014 04:44 AM, Chengwei Yang wrote:
> > The implementation is, "." following the file permission mode bits
> > indicates both SELinux and SMACK access method, so fix the document.
> > 
> > Also in its help info, so the manpage generated from help into.
> 
> > --- a/src/ls.c
> > +++ b/src/ls.c
> > @@ -4886,7 +4886,7 @@ Sort entries alphabetically if none of -cftuvSUX nor 
> > --sort is specified.\n\
> >    -w, --width=COLS           assume screen width instead of current 
> > value\n\
> >    -x                         list entries by lines instead of by columns\n\
> >    -X                         sort alphabetically by entry extension\n\
> > -  -Z, --context              print any SELinux security context of each 
> > file\n\
> > +  -Z, --context              print any SELinux or SMACK security context 
> > of each file\n\
> 
> This is a bit long and will get out of date if we ever have
> support for other LSMs, so I'll s/SELinux or SMACK//.

Yes, document is the last thing we can remember to keep it update. Just
like the SMACK support doesn't use "+" that suggested by document but
reuse "." which document says only for SELinux.

If you do so, I think you need also delete "+" parts in document and
source code, then all the other new LSMs will reuse "." to indicates the
file has LSM context.

--
Thanks,
Chengwei

> 
> thanks,
> Pádraig.

signature.asc
Description: Digital signature