coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ls & cksum: Small test improvements


From: Pádraig Brady
Subject: Re: ls & cksum: Small test improvements
Date: Sun, 20 Oct 2024 14:13:15 +0100
User-agent: Mozilla Thunderbird Beta

On 20/10/2024 09:30, Sylvestre Ledru wrote:

Le 19/10/2024 à 14:02, Pádraig Brady a écrit :
On 18/10/2024 22:17, Sylvestre Ledru wrote:
Hello

These two patches improve the test coverage of ls & cksum.

The first patch tests that symlink with --dired are correctly positioned.

The second that comments on a checksum files aren't causing any
validation issues (but impacts the line number).
The first patch induces a failure on btrfs at least,
due to the non determination of directory order with the -f option.
For me the result is:

    drwxr-xr-x. 1 padraig padraig 40 Oct 19 12:58 .  drwx------. 1 padraig 
padraig 18 Oct 19 12:58 ..
    -rw-r--r--. 1 padraig padraig  0 Oct 19 12:58 1a
    -rw-r--r--. 1 padraig padraig  0 Oct 19 12:58 2á
    drwxr-xr-x. 1 padraig padraig  0 Oct 19 12:58 3dir
    -rw-r--r--. 1 padraig padraig  0 Oct 19 12:58 aaa
    lrwxrwxrwx  1 padraig padraig  6 Oct 19 12:58 aaa_link -> target

Why did you add the -f option?

just an oversight, sorry. I removed it as the goal is to test dired positions with 
symlinks (0aaa_link -> target)

Here is a better version :)

Pushed with tweaks to pass `make syntax-check`.

thanks!

Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]