coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: protect ulimit -v determination with a timeout


From: Bernhard Voelker
Subject: Re: [PATCH] tests: protect ulimit -v determination with a timeout
Date: Wed, 15 Jan 2025 08:33:13 +0100
User-agent: Mozilla Thunderbird

Hi Padraig,

On 1/15/25 02:36, Pádraig Brady wrote:
This avoids a test hang seen with bash on Solaris 11

+  # Wrap with timeout as on some systems (like Solaris 11)
+  # fork() can return EAGAIN under vm constraints,
+  # causing bash at least to loop retrying the fork

thanks, the reasoning becomes clear with this.

+  timeout 1 true >/dev/null ||
+    skip_ 'ulimit -v cannot be safely checked'

-    ulimit -v $v && "$@"
-  ) >/dev/null 2>&1
+  timeout 10 $SHELL "$abs_srcdir"/tests/ulimit_supported "$@"

ulimit_supported is mainly used by get_min_ulimit_v_ for a given
coreutils tool, while the above now uses $SHELL in between:
isnt't that usually much larger than our tools, and hence the
resulting minimum ulimit_v will be wrong then?

Have a nice day,
Berny





reply via email to

[Prev in Thread] Current Thread [Next in Thread]