[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Debian-sf-devel] ["Lamoureux, Robert" <address@hidden>] Updated Patch f

From: Roland Mas
Subject: [Debian-sf-devel] ["Lamoureux, Robert" <address@hidden>] Updated Patch file
Date: Fri, 25 Oct 2002 18:55:01 +0200
User-agent: Gnus/5.090008 (Oort Gnus v0.08) Emacs/21.2 (i386-debian-linux-gnu)

  People, good day.

  Here's a patch by Robert Lamoureux.  He seems to be too shy to post
it to a public list before it's 100% perfect, but there's no shame in
it.  "Release early, release often", they say.

  The current version of this patch seems rather good, except for the
debian/control file.  I'm not sure the sourceforge-cronolog package is
needed, but I'm pretty sure that 1. it'll need to depend on cronolog,
2. the sourceforge package will need to depend on it always (as
opposed to sourceforge-cronolog OR sourceforge-lists-mailman OR
sourceforge-lists, as the patch currently does).

  Barring that, come on Bob, own up!  It's good!  I hope you'll post
next version on the Savannah patch tracher :-)

--- Begin Message --- Subject: Updated Patch file Date: Fri, 25 Oct 2002 09:57:05 -0400

Let's see if this patch is any better.  I made changed to the
changelog/rules and control file per your request. 

Let me know how this goes.


P.S  I have another separate patch working on the themes problems I have
uncovered.  The themes stuff does not work completely correctly and I have
been fixing that section lately.

-----Original Message-----
From: Roland Mas [mailto:address@hidden 
Sent: Friday, October 25, 2002 8:06 AM
To: Lamoureux, Robert
Subject: Re: [Debian-sf-devel] Re: Patch files for you to check out

  Hi Bob,

Lamoureux, Robert (2002-10-23 10:10:41 -0400) :

> Before I make a major fool of myself in a public forum, I would like 
> to ask you to check this over before I post it.

Oh come on, don't be shy :-)  Making a fool of oneself is not an offense
(except when you're obnoxious).  Especially when you're offering a large

> I have made an aggregated patch file that contains the first two files 
> I sent you, plus the others I have worked on.  The changes were fairly 
> straightforward, but the number of files touched is high (8-10 I 
> believe).

  Okay.  The form of the patch itself is 100% correct, so there's no trouble
there.  The contents are not perfect, but I'll come to that.

> More importantly, my solution introduces a dependancy for the package 
> that I am not sure how to handle.

  You'll need to add the package name (and optionnally a version) to the
appropriate Depends: line of the debian/control file.

> It seems that the stats jobs all assumed a hierarchical directory 
> structure for the log files that are used as the basis for the stats.  
> That means that the apache web files must be placed into subdirs base 
> don the date.  The easiest way I could see to do that was to install 
> the 'cronolog' package.  This package was simple and easy to add and 
> it seems to work just fine.

  That's cool.  I'm a bit worried about having an extra dependency, though.
If you just use cronolog to split the logs into files, it might be better to
reimplement that feature (or copy and paste it from
cronolog) into a script included in the package.  Note I'm absolutely not
sure about that, it's just a "might" for now.

> I do not know where to speficy the fact that this package has a new 
> dependancy, but I have made all the other changes to the files in 
> order to get most of the stats running.

  See above.

> I made lots of changelog entries for your review.

  Nice.  Maybe you'd care to add your full name and email address at least

> Please let me know what you think before I do my first Open Source 
> patch (pretty old to be a virgin, eh? ;)

  Overall impression is very positive :-)  Just a few quirks to iron out,
and I'll probably apply and commit the patch.

Roland Mas

Sauvez les castors, imprimez en recto-verso.

Attachment: stats_patch_Oct25
Description: Binary data

--- End Message ---

Roland Mas

Un clavier azerty en vaut deux.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]